Skip to content

Extract TTSIM #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 24, 2025
Merged

Extract TTSIM #1052

merged 10 commits into from
Jul 24, 2025

Conversation

@hmgaudecker
Copy link
Collaborator

@hmgaudecker hmgaudecker commented Jul 24, 2025

In sync with TTSIM PR 1, this leaves just GETTSIM in here.

Will also tackle #1003 in the process.

@hmgaudecker hmgaudecker changed the base branch from main to collect-components-of-namespaces July 24, 2025 08:51
@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.65%. Comparing base (ad1d40e) to head (626c002).

Files with missing lines Patch % Lines
src/_gettsim/arbeitslosengeld_2/regelbedarf.py 0.00% 1 Missing ⚠️
src/_gettsim/grundsicherung/im_alter/einkommen.py 0.00% 1 Missing ⚠️
src/_gettsim/kinderzuschlag/kinderzuschlag.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                          Coverage Diff                          @@
##           collect-components-of-namespaces    #1052       +/-   ##
=====================================================================
- Coverage                             78.03%   60.65%   -17.38%     
=====================================================================
  Files                                   180      107       -73     
  Lines                                  8039     3083     -4956     
=====================================================================
- Hits                                   6273     1870     -4403     
+ Misses                                 1766     1213      -553

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hmgaudecker hmgaudecker linked an issue Jul 24, 2025 that may be closed by this pull request
ENH: Expose more elements in GETTSIM interface #1003
Closed
@hmgaudecker hmgaudecker requested a review from MImmesberger July 24, 2025 13:11
MImmesberger
MImmesberger approved these changes Jul 24, 2025
View reviewed changes
Copy link
Collaborator

@MImmesberger MImmesberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of gettsim.tt, mainly because it's not immediately clear what the tt module is supposed to be. Maybe gettsim.ttsim_objects? Alternatively gettsim.core or gettsim.policy_objects?

@hmgaudecker
Copy link
Collaborator Author

hmgaudecker commented Jul 24, 2025

I'm not a huge fan of gettsim.tt, mainly because it's not immediately clear what the tt module is supposed to be. Maybe gettsim.ttsim_objects? Alternatively gettsim.core or gettsim.policy_objects?

As discussed, let's leave it at that for now -- can always change before the new release, after all, ttsim is only in alpha stage (but would have to change there, too).

@hmgaudecker hmgaudecker merged commit ae759f4 into collect-components-of-namespaces Jul 24, 2025
13 checks passed
@hmgaudecker hmgaudecker deleted the extract-ttsim branch July 24, 2025 14:22
@hmgaudecker hmgaudecker mentioned this pull request Jul 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MImmesberger MImmesberger MImmesberger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ENH: Expose more elements in GETTSIM interface

3 participants

@hmgaudecker @MImmesberger